This repository was archived by the owner on Aug 31, 2023. It is now read-only.
refactor(rome_service): use serde::Diagnostic in the workspace
#3450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serde::Diagnostic in the workspace
94188fd to
17c4b25
Compare
Base automatically changed from
refactor/use-new-diagnostics-in-rules
to
refactor-diagnostics
October 19, 2022 16:38
42c571f to
1e29187
Compare
…om parsing and analyzer
1e29187 to
ef3f16f
Compare
leops
reviewed
Oct 20, 2022
crates/rome_js_analyze/src/analyzers/correctness/no_double_equals.rs
Outdated
Show resolved
Hide resolved
MichaReiser
reviewed
Oct 21, 2022
MichaReiser
reviewed
Oct 21, 2022
crates/rome_js_analyze/src/analyzers/correctness/no_double_equals.rs
Outdated
Show resolved
Hide resolved
ematipico
added a commit
that referenced
this pull request
Oct 25, 2022
ematipico
added a commit
that referenced
this pull request
Oct 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR joins the refactored diagnostics of JS parser and analyzer into a single data structure, which
v2::serde::Diagnostics.In theory, once this PR is merged, we could start merging the code in
main.Test Plan
CLI tests passed locally.
The command
cargo lintdocnow works