This repository was archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_cli): Add server logs to rage command
#3441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3e0c5e to
25b5db3
Compare
✅ Deploy Preview for rometools canceled.
|
25b5db3 to
3459c3b
Compare
✅ Deploy Preview for rometools canceled.
|
MichaReiser
commented
Oct 18, 2022
| impl<S> Filter<S> for LoggingFilter { | ||
| fn enabled(&self, meta: &Metadata<'_>, _cx: &Context<'_, S>) -> bool { | ||
| impl LoggingFilter { | ||
| fn is_enabled(&self, meta: &Metadata<'_>) -> bool { |
There was a problem hiding this comment.
Example implementation from the Filter::enabled documentation for cases where the filter's interest solely depends on the metadata but not on some internal state. source
ragerage command
leops
reviewed
Oct 18, 2022
crates/rome_cli/tests/snapshots/main_commands_rage/rage_ok.snap
Outdated
Show resolved
Hide resolved
ematipico
approved these changes
Oct 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the server log to the output of the
ragecommand.I initially considered implementing the LSP
tracenotification but preferred to not go with it in the end because:ragewas runrome/ragecommand has completed. It would be necessary to implement some wait mechanism on the client to give the server time to send the notifications and then consume every one of them.I still plan to spend some time today to explore if it is possible to implement the trace notification because that can be useful when debugging the VS Code plugin but I no longer plan to use it for the
ragecommand.Test Plan
I added a new test (that was painful because of race conditions)
Open Question
--include-logsargument is present?