This repository was archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_diagnostics_macros): correctly ignore unknown attributes #3433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rometools canceled.
|
ematipico
approved these changes
Oct 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Rust Compiler already has a mechanism in place to emit an error when an unknown attribute is used in the code, so the procedural macro should simply ignore attributes it doesn't known about. Not only does this prevent a duplicate diagnostic from being emitted, but it's also important to allow attributes from the language (such as the
#[doc = ""]attribute that doc-comments desugar to) or other proc-macros on types that deriveDiagnosticTest Plan
The "unknown attribute" case is already covered but the test suite of the macro, the snapshot has been updated to ensure that only one diagnostic is emitted by the compiler.