This repository was archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_js_formatter): JSX Expression child closing parentheses #3376 #3432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rometools canceled.
|
denbezrukov
commented
Oct 15, 2022
| @@ -155,6 +155,12 @@ impl FormatNodeRule<JsArrowFunctionExpression> for FormatJsArrowFunctionExpressi | |||
| Some(GroupedCallArgumentLayout::GroupedLastArgument) | |||
| ); | |||
|
|
|||
| let should_add_soft_line = is_last_call_arg | |||
There was a problem hiding this comment.
MichaReiser
approved these changes
Oct 17, 2022
MichaReiser
reviewed
Oct 17, 2022
| soft_line_break() | ||
| ]) | ||
| is_last_call_arg | ||
| .then_some(format_args![if_group_breaks(&text(",")),]), |
There was a problem hiding this comment.
Oh no, you'll end up with merge conflicts :(
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #3376
Test Plan
cargo test -p rome_js_formatter