This repository was archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_formatter): trailing comma option #3305 #3430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
8d70415 to
1a57648
Compare
MichaReiser
approved these changes
Oct 17, 2022
| dsadsadasdasdasdasdasdasdasd, | ||
| dsadsadasdasdasdasdasdasdasd, | ||
| ] = [1, 2, 10]; | ||
| ## Output 2 |
There was a problem hiding this comment.
Nit: Unrelated to your change but something we may want to change in another PR. We should wrap the code in "```" and ensure there is at least one new line between the code and the Output titles.
There was a problem hiding this comment.
I will do so after this PR is merged.
...es/rome_js_formatter/tests/specs/js/module/array/trailing-comma/array_trailing_comma.js.snap
Outdated
Show resolved
Hide resolved
f671b30 to
a96b95b
Compare
a96b95b to
fc99a71
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for a trailing_comma option that can either be
es5orall(default)Close #3305
Test Plan
Add new snapshots
cargo test -p rome_js_formatter