+
Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

feat(rome_cli): Add version command #3421

Merged
merged 5 commits into from
Oct 17, 2022
Merged

feat(rome_cli): Add version command #3421

merged 5 commits into from
Oct 17, 2022

Conversation

MichaReiser
Copy link
Contributor

@MichaReiser MichaReiser commented Oct 13, 2022 •
edited
Loading

Summary

This PR adds the new rome version and rome --version commands as described in #3410.

Test Plan

I ran the Release CLI and Release LSP workflows, downloaded the binaries and tested the new version commands:

❯ ./rome-linux-x64 --version
Rome CLI version 0.10.1-next.2d7c920

~/Downloads 
❯ ./rome-linux-x64 version
CLI:        0.10.1-next.2d7c920
Server:     disconnected

# Connected to LSP version from main
~/Downloads 
❯ ./rome-linux-x64 version --use-server
CLI:        0.10.1-next.2d7c920
Server:
  Name:     rome_lsp
  Version:  0.0.0

# Version spawned by preview build
❯ ./rome-linux-x64 version --use-server
CLI:        0.10.1-next.2d7c920
Server:
  Name:     rome_lsp
  Version:  0.10.1-next.2d7c920

I added new snapshot tests for rome version.

Open Questions

  • Should the status be not connected instead of disconnected because disconnected sounds like it should be connected but is not. Alternatives would be to print a - or None

@MichaReiser MichaReiser temporarily deployed to netlify-playground October 13, 2022 12:51 Inactive
@netlify
Copy link

netlify bot commented Oct 13, 2022 •
edited
Loading

✅ Deploy Preview for rometools canceled.

Name Link
🔨 Latest commit a262d21
🔍 Latest deploy log https://app.netlify.com/sites/rometools/deploys/634d1841977e4e00087ed82f

@MichaReiser MichaReiser changed the base branch from main to refactor/split-cli-tests October 13, 2022 12:51
@MichaReiser MichaReiser linked an issue Oct 13, 2022 that may be closed by this pull request
📎 Add version command #3410
Closed
3 tasks
@MichaReiser MichaReiser changed the title refactor(rome_cli): Split CLI tests feat(rome_cli): Add version command Oct 13, 2022
@github-actions
Copy link

github-actions bot commented Oct 13, 2022 •
edited
Loading

Playground for commit 4a36477

Base automatically changed from refactor/split-cli-tests to main October 13, 2022 15:36
@MichaReiser MichaReiser temporarily deployed to netlify-playground October 13, 2022 16:38 Inactive
@MichaReiser MichaReiser marked this pull request as ready for review October 13, 2022 16:38
@MichaReiser MichaReiser requested a review from a team October 13, 2022 16:38
@calibre-analytics
Copy link

calibre-analytics bot commented Oct 13, 2022 •
edited
Loading

Comparing feat(rome_cli): Add version command Snapshot #7 to median since last deploy of rome.tools.

LCP? CLS? TBT?
Overall
Median across all pages and test profiles		 1.97s 
from 555ms		 0.0
no change		 144ms 
from 45ms
Chrome Desktop
Chrome Desktop • Cable		 1.97s 
from 579ms		 0.0
no change		 423ms 
from 235ms
iPhone, 4G LTE
iPhone 12 • 4G LTE		 860ms 
from 218ms		 0.0
no change		 20ms 
from 6ms
Motorola Moto G Power, 3G connection
Motorola Moto G Power • Regular 3G		 13.3s 
from 555ms		 0.0
no change		 144ms 
from 45ms

1 page tested

 Home

Browser previews

Chrome Desktop iPhone, 4G LTE Motorola Moto G Power, 3G connection
Chrome Desktop iPhone, 4G LTE Motorola Moto G Power, 3G connection

Most significant changes

Value Budget
JS Parse & Compile
iPhone, 4G LTE		 419ms 
from 8ms
Total JavaScript Size in Bytes
Chrome Desktop		 4.32 MB 
from 86.8 KB
Total JavaScript Size in Bytes
iPhone, 4G LTE		 4.32 MB 
from 86.8 KB
Total JavaScript Size in Bytes
Motorola Moto G Power, 3G connection		 4.32 MB 
from 86.8 KB
JS Parse & Compile
Motorola Moto G Power, 3G connection		 1.47s 
from 29ms

28 other significant changes: JS Parse & Compile on Chrome Desktop, First Contentful Paint on Motorola Moto G Power, 3G connection, Largest Contentful Paint on Motorola Moto G Power, 3G connection, Speed Index on Motorola Moto G Power, 3G connection, Total Page Size in Bytes on Chrome Desktop, Total Page Size in Bytes on iPhone, 4G LTE, Total Page Size in Bytes on Motorola Moto G Power, 3G connection, Number of Requests on Chrome Desktop, Number of Requests on iPhone, 4G LTE, Number of Requests on Motorola Moto G Power, 3G connection, Time to Interactive on Motorola Moto G Power, 3G connection, First Contentful Paint on Chrome Desktop, Time to Interactive on Chrome Desktop, First Contentful Paint on iPhone, 4G LTE, Speed Index on Chrome Desktop, Speed Index on iPhone, 4G LTE, Time to Interactive on iPhone, 4G LTE, Largest Contentful Paint on iPhone, 4G LTE, Largest Contentful Paint on Chrome Desktop, Total Blocking Time on Motorola Moto G Power, 3G connection, Total Image Size in Bytes on Chrome Desktop, Total Image Size in Bytes on iPhone, 4G LTE, Total Image Size in Bytes on Motorola Moto G Power, 3G connection, Total HTML Size in Bytes on Chrome Desktop, Total HTML Size in Bytes on iPhone, 4G LTE, Total HTML Size in Bytes on Motorola Moto G Power, 3G connection, Lighthouse Performance Score on Motorola Moto G Power, 3G connection, Lighthouse Performance Score on Chrome Desktop

Calibre: Site dashboard | View this PR | Edit settings | View documentation

@MichaReiser MichaReiser temporarily deployed to netlify-playground October 14, 2022 06:34 Inactive
@ematipico
Copy link
Contributor

Should the status be not connected instead of disconnected because disconnected sounds like it should be connected but is not. Alternatives would be to print a - or None

I like more not connected

@MichaReiser MichaReiser temporarily deployed to netlify-playground October 17, 2022 08:54 Inactive
@MichaReiser MichaReiser merged commit 5e96b2a into main Oct 17, 2022
@MichaReiser MichaReiser deleted the feat/version-command branch October 17, 2022 09:17
@MichaReiser MichaReiser temporarily deployed to netlify-playground October 17, 2022 09:18 Inactive
@ematipico ematipico mentioned this pull request Oct 27, 2022
Closed
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ematipico ematipico ematipico approved these changes

@leops leops Awaiting requested review from leops

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

📎 Add version command
2 participants
@MichaReiser @ematipico
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载