+
Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

ci: publish workflow for @rometools/js-api package #3402

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

ematipico
Copy link
Contributor

Summary

This PR adds a new publish workflow for the new package @rometools/js-api.

The majority of the code was copied from the existing workflows.

Test Plan

As it's a new package, the only way to test would be to actually merge and see if:

  • the nightly release works
  • change the package.json version will kick a stable release

@ematipico ematipico requested a review from a team October 11, 2022 14:35
@netlify
Copy link

netlify bot commented Oct 11, 2022

Deploy Preview for rometools canceled.

Name Link
🔨 Latest commit 5240d9a
🔍 Latest deploy log https://app.netlify.com/sites/rometools/deploys/634588cecd953e0007ac0f0b

@ematipico ematipico changed the title ci: publish workflow ci: publish workflow for @rometools/js-api package Oct 11, 2022
Copy link
Contributor

@leops leops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the new workflow has the workflow_dispatch trigger isn't it possible to dispatch it manually from the branch before merging to test it ?

@ematipico ematipico force-pushed the ci/publish-workflow-js-api branch from 1e6dbc6 to 3164589 Compare October 11, 2022 15:15
@ematipico ematipico force-pushed the ci/publish-workflow-js-api branch from 3164589 to 5240d9a Compare October 11, 2022 15:16
@ematipico
Copy link
Contributor Author

Since the new workflow has the workflow_dispatch trigger isn't it possible to dispatch it manually from the branch before merging to test it ?

Unfortunately it doesn't work for new-created workflows. In order to manually trigger workflows, first they have to be merged on main.

@ematipico ematipico merged commit 0438968 into main Oct 17, 2022
@ematipico ematipico deleted the ci/publish-workflow-js-api branch October 17, 2022 07:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载