This repository was archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_formatter): Object Pattern Formatting #3405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR aligns the object pattern formatting with prettier. Mainly the logic when to expand a pattern over multiple lines. This PR further adds an extension trait for `Option<SyntaxNode<L>>` that implements a `kind` helper. I don't remember how many times I've written `node.parent().map(|p| p.kind())`... This new extension trait now allows to simply write `node.parent().kind()`. ## Tests I verified that the tests mentioned in #3295 are fixed. **Average compatibility**: 91.84 -> 91.98 **Compatible lines**: 93.85 -> 93.95
✅ Deploy Preview for rometools canceled.
|
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
ematipico
approved these changes
Oct 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aligns the object pattern formatting with prettier. Mainly the logic when to expand a pattern over multiple lines.
This PR further adds an extension trait for
Option<SyntaxNode<L>>that implements akindhelper. I don't remember how many times I've writtennode.parent().map(|p| p.kind())... This new extension trait now allows to simply writenode.parent().kind().Tests
I verified that the tests mentioned in #3295 are fixed.
Average compatibility: 91.84 -> 91.98
Compatible lines: 93.85 -> 93.95