This repository was archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_js_formatter): Fix arrow binding parameter in test call #3399
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rome has special formatting for test calls that ensures that callbacks remain on the same line as the
it
ordescribe
even if exceeding the configured print width. This check was missing for arrow function expression with a single binding parameter so that formattingfirst resulted in
and ultimately in
This PR removes the need for a second formatting pass by picking up the test call layout in the arrow function binding parameter formatting.
Tests
I added a new snapshot test and verified that formatting the ant-design project twice yields no more formatting changes.