This repository was archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_js_formatter): Arrow chain trailing comments #3398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes an issue where trailing comments of arrow expressions that are part of an arrow chain (arrow expressions that are the body of another arrow) were dropped. The manual handling of comments is necessary because the arrow chain formatting doesn't call into the `FormatJsArrowFunctionExpression` of nested arrow functions. The implementation already handles the formatting of leading comments correctly. ## Tests I added a new snapshot test and verified that running rome format on prettier yields no more "dropped comments" errors.
✅ Deploy Preview for rometools canceled.
|
ematipico
approved these changes
Oct 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where trailing comments of arrow expressions that are part of an arrow chain (arrow expressions that are the body of another arrow) were dropped.
The manual handling of comments is necessary because the arrow chain formatting doesn't call into the
FormatJsArrowFunctionExpressionof nested arrow functions.The implementation already handles the formatting of leading comments correctly.
Tests
I added a new snapshot test and verified that running rome format on prettier yields no more "dropped comments" errors.