This repository was archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_analyze): new rule noRestrictedGlobals
#3342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rometools ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
586bcfc to
44f4b42
Compare
44f4b42 to
ab159bd
Compare
|
Comparing feat(rome_js_analyze): new rule
1 page tested
|
| Chrome Desktop | iPhone, 4G LTE | Motorola Moto G Power, 3G connection |
|---|---|---|
 |
 |
 |
Most significant changes
 |
Value | Budget |
|---|---|---|
| Total JavaScript Size in Bytes Chrome Desktop |
1.24 MB  from 86.8 KB |
 |
| Total JavaScript Size in Bytes iPhone, 4G LTE |
1.24 MB from 86.8 KB |
|
| Total JavaScript Size in Bytes Motorola Moto G Power, 3G connection |
1.24 MB from 86.8 KB |
|
| Number of Requests iPhone, 4G LTE |
40  from 5 |
|
| Number of Requests Chrome Desktop |
39  from 5 |
|
4 other significant changes: Number of Requests on Motorola Moto G Power, 3G connection, Total Page Size in Bytes on Chrome Desktop, Total Page Size in Bytes on iPhone, 4G LTE, Total Page Size in Bytes on Motorola Moto G Power, 3G connection
Calibre: Site dashboard | View this PR | Edit settings | View documentation
xunilrj
reviewed
Oct 7, 2022
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_restricted_globals.rs
Outdated
Show resolved
Hide resolved
xunilrj
reviewed
Oct 7, 2022
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_restricted_globals.rs
Show resolved
Hide resolved
8584ded to
09a286e
Compare
leops
approved these changes
Oct 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3341
Closes #2978
Test Plan
Added some test case