This repository was archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_analyze): use serde to deserialize rule settings #3347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rometools ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
leops
reviewed
Oct 5, 2022
4812017 to
bb271aa
Compare
xunilrj
reviewed
Oct 7, 2022
bb271aa to
2f8980e
Compare
leops
approved these changes
Oct 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3343
Closes #3344
Closes #3345
The function
rule_optionshas been renamedrule_settingsand it's been lifted inside theAnalyzerContext. TheAnalyzerContextnow accepts aRuleKey, which is needed to retrieve and deserialize the JSON string coming from the configuration.serdeis not optional anymore (I thought the entity of the change was bigger).The handling of the error has been left out on purpose for the time being, and it will be handled in a different PR
Test Plan
The current CI should work