This repository was archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_analyzer): add noPositiveTabindex rule
#3336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
kaioduarte
commented
Oct 5, 2022
There was a problem hiding this comment.
I'm opening a draft PR so we can discuss the implementation.
While implementing the rule, I noticed that the helper inner_string_text couldn't strip the quotes on JsxSelfClosingElement. Can you confirm this is working as intended, or is it a bug?
The same also happens when getting the value for JsNumberLiteralExpression and JsStringLiteralExpression on React.createElement.
Any help is appreciated!
crates/rome_js_analyze/tests/specs/nursery/noPositiveTabindex/invalidJsx.jsx
Outdated
Show resolved
Hide resolved
50e5749 to
88fed27
Compare
f380389 to
85bd430
Compare
ematipico
suggested changes
Oct 6, 2022
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_positive_tabindex.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_positive_tabindex.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_positive_tabindex.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_positive_tabindex.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_positive_tabindex.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_positive_tabindex.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_positive_tabindex.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_positive_tabindex.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_positive_tabindex.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_positive_tabindex.rs
Outdated
Show resolved
Hide resolved
85bd430 to
c328cd5
Compare
ematipico
suggested changes
Oct 10, 2022
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_positive_tabindex.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_positive_tabindex.rs
Show resolved
Hide resolved
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_positive_tabindex.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_positive_tabindex.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/tests/specs/nursery/noPositiveTabindex/invalidJsx.jsx.snap
Show resolved
Hide resolved
crates/rome_js_analyze/src/semantic_analyzers/nursery/no_positive_tabindex.rs
Outdated
Show resolved
Hide resolved
leops
approved these changes
Oct 10, 2022
e6b61b5 to
29a7f19
Compare
ematipico
approved these changes
Oct 10, 2022
|
sorry, forgot to update doc files 😞 |
No worries. To fix the CI issue, you need to run |
c849448 to
7995651
Compare
|
There was a change right after my last rebase that I missed, hopefully it will be green now 🤞🏻💚 |
…ive_tabindex.rs Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
…ive_tabindex.rs Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
…ive_tabindex.rs Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
…ive_tabindex.rs Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
7995651 to
2e2ea17
Compare
noPositiveTabindex rule
noPositiveTabindex rulenoPositiveTabindex rule
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3304
Test Plan