+
Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

chore(rome_js_anlayze): split test case of useOptionalChain into multiple parts #3312

Merged

Conversation

IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented Oct 3, 2022

Summary

  1. Split test cases of useOptionalChain into multiple parts to make test running parallel
  2. from https://github.com/rome/tools/pull/3258/files
    image

Test Plan

  1. The CI should pass.

@netlify
Copy link

netlify bot commented Oct 3, 2022

Deploy Preview for docs-rometools ready!

Name Link
🔨 Latest commit 95e8b91
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/633ad288aa17bc0008d0cf42
😎 Deploy Preview https://deploy-preview-3312--docs-rometools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@IWANABETHATGUY IWANABETHATGUY force-pushed the chore/split-use-optional-chain-tests branch from 6e3d938 to 95e8b91 Compare October 3, 2022 12:16
@IWANABETHATGUY IWANABETHATGUY changed the title chore: 🤖 fiinsh chore(rome_js_anlayze): split test case of useOptionalChain into multiple parts Oct 3, 2022
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review October 3, 2022 12:18
@IWANABETHATGUY
Copy link
Contributor Author

Split crates/rome_js_analyze/tests/specs/nursery/useOptionalChain/logicalAndCases.js into 6 parts, each part about 65 lines.
Split crates/rome_js_analyze/tests/specs/nursery/useOptionalChain/nullishAndLogicalOr.ts into two parts, each part about 75 lines.

@ematipico ematipico merged commit 18df7bf into rome:main Oct 3, 2022
@ematipico ematipico added the A-Linter Area: linter label Oct 3, 2022
@IWANABETHATGUY IWANABETHATGUY deleted the chore/split-use-optional-chain-tests branch October 3, 2022 12:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Linter Area: linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载