This repository was archived by the owner on Aug 31, 2023. It is now read-only.
refactor(rome_diagnostics): change FileId from a type alias to a newtype struct #3232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rometools canceled.
|
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
ematipico
approved these changes
Sep 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a change I extracted from #3222 to make the larger change easier to review. This PR changes the
FileIdtype inrome_diagnosticsfrom an alias ofusizeto a proper newtype struct. This makes is easier to implement specific behaviors and traits on that type, and could eventually allow us to change the internal representation of File IDs transparently for consumers of the type.Test Plan
This is purely a type-level change, it should not impact the functionality of the code (for the most part the machine code generated by the compile should not change and the
FileIdstruct should have the same memory layout as a rawusize)