This repository was archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_rowan): Expose SyntaxElementKey
#3229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes the `SyntaxElementKey` public. The `key` methods already have been public but the type itself wasn't, preventing it to e.g. be used as keys in a `HashMap`.
✅ Deploy Preview for rometools ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ematipico
approved these changes
Sep 15, 2022
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
leops
approved these changes
Sep 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes the
SyntaxElementKeypublic. Thekeymethods already have been public but the type itself wasn't, preventing it to e.g. be used as keys in aHashMap.The Comments refactoring uses
SyntaxElementKeyasHashMapkeys which is why it is necessary to use the type in other crates. An alternative would have been to useSyntaxNodeandSyntaxTokenas keys. However, this has the downside that all keys must be deallocated after formatting a file whereas the compiler may be able to optimize the drop away when using the key.Test Plan
cargo build