You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Aug 31, 2023. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
Some of the snapshots are detected by Git as having been deleted and added instead of being moved (flipBinExp, inlineVariable, noLabelVar, noNegationElse), I think this may indicate they haven't been moved to the correct directory as the resulting snapshot content is different enough that Git doesn't detect it as the same file
Some of the snapshots are detected by Git as having been deleted and added instead of being moved (flipBinExp, inlineVariable, noLabelVar, noNegationElse), I think this may indicate they haven't been moved to the correct directory as the resulting snapshot content is different enough that Git doesn't detect it as the same file
I fixed the snapshots, but for noLabelVar there's something strange: the old snapshot didn't have any diagnostic and the new one (the correct one) now has the diagnostic
Some of the snapshots are detected by Git as having been deleted and added instead of being moved (flipBinExp, inlineVariable, noLabelVar, noNegationElse), I think this may indicate they haven't been moved to the correct directory as the resulting snapshot content is different enough that Git doesn't detect it as the same file
I fixed the snapshots, but for noLabelVar there's something strange: the old snapshot didn't have any diagnostic and the new one (the correct one) now has the diagnostic
For noLabelVar I think it was the other way around, the file wasn't in the correct directory in the first place, but it is now
The reason will be displayed to describe this comment to others. Learn more.
The diagnostics for noNegationElse are still missing from the snapshots, I think we should have a safety check in the analyzer tests that verifies the path of the snapshots files correspond to the rule instead of failing silently
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Relevant discussion #3017 (comment)
This PR refactor the group names, please read the relevant discussion for more details.
Test Plan
Updated documentation, CLI tests, analyzer tests. The CI should pass because no new functionality has been implemented.