This repository was archived by the owner on Aug 31, 2023. It is now read-only.
test(rome_cli): snap termination error #3186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rometools canceled.
|
ematipico
commented
Sep 8, 2022
| @@ -16,4 +15,8 @@ expression: content | |||
| } | |||
| ``` | |||
|
|
|||
| # Termination Message | |||
|
|
|||
| Rome couldn't load the configuration file, here's why: | |||
There was a problem hiding this comment.
This line was repeated twice. The introduction of ConfigurationError:UnknownRule fixed the issue.
19c0063 to
3b1e903
Compare
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
leops
approved these changes
Sep 9, 2022
crates/rome_cli/tests/snap_test.rs
Outdated
| } | ||
|
|
||
| impl CliSnapshot { | ||
| pub fn form_result(result: Result<(), Termination>) -> Self { |
There was a problem hiding this comment.
This looks like a typo:
Suggested change
| pub fn form_result(result: Result<(), Termination>) -> Self { | |
| pub fn from_result(result: Result<(), Termination>) -> Self { |
c1aaef2 to
d6b1ed7
Compare
d6b1ed7 to
a2376ec
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR increases the coverage of the snapshots of the CLI tests, by tracking the
Terminationmessage emitted in case of errors.All the snapshots that result in errors are updated. While doing so, I found a bug in how we construct the error message of the rules and fixed it.
Test Plan
Manually checked that the termination messages are printed in the snapshots