This repository was archived by the owner on Aug 31, 2023. It is now read-only.
chore: Replace num_cpus crate with std call
#3163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rometools ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
ematipico
approved these changes
Sep 6, 2022
| pool: &yastl::Pool::new( | ||
| std::thread::available_parallelism() | ||
| .map_or(2, |num| usize::from(num)) | ||
| .max(2), |
There was a problem hiding this comment.
If we use max as limit, is it possible to just use map?
There was a problem hiding this comment.
The max is required so that we still spawn at least two threads if available_parallelism returns 1 because the testing framework has one "orchestration" thread and at least one to run the tests.
Use `std::thread::available_parallelism()` over `num_cpus`
bd23de2 to
c75106e
Compare
ematipico
pushed a commit
that referenced
this pull request
Sep 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
std::thread::available_parallelism()overnum_cpusinxtask coverageTest Plan
xtask coverage