+
Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

feat(playground): implement option quote_properties #3121

Merged
merged 2 commits into from
Aug 29, 2022

Conversation

bhbs
Copy link
Contributor

@bhbs bhbs commented Aug 28, 2022

Summary

  • Implemented Quote Properties to playground!
  • Quote Type -> Quote Style

Relevant issue

Test Plan

AsNeeded / Preserve

AsNeeded

AsNeeded

Preserve

Preserve

PC (before / after) / SP (before / after)

PC (before / after)

before

pc_before

after

pc_after

SP (before / after)

before

iPhone SE before

after

iPhone SE after

@bhbs bhbs requested a review from a team August 28, 2022 15:09
Copy link
Contributor

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Let's change the AsPreserve to As preserve to make it easier to read and we're good

setQuoteProperties(e.target.value as QuoteProperties)}
className="w-[100px] mt-1 block w-full pl-3 pr-10 py-2 text-base border-gray-300 focus:outline-none focus:ring-indigo-500 focus:border-indigo-500 sm:text-sm rounded-md"
>
<option value={QuoteProperties.AsNeeded}>AsNeeded</option>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<option value={QuoteProperties.AsNeeded}>AsNeeded</option>
<option value={QuoteProperties.AsNeeded}>As needed</option>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certainly 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and wide enough 🙆‍♂️

スクリーンショット 2022-08-29 18 31 18

スクリーンショット 2022-08-29 18 31 34

Co-authored-by: Micha Reiser <micha@reiser.io>
Copy link
Contributor

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's an amazing addition! Thank you!

@ematipico ematipico merged commit d616726 into rome:main Aug 29, 2022
@bhbs bhbs deleted the feature/playground-quote-properties branch August 29, 2022 11:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载