This repository was archived by the owner on Aug 31, 2023. It is now read-only.
refactor(rome_wasm): change method names to be camel case #3105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
1ec689f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://02ae3ef5.tools-8rn.pages.dev |
| Branch Preview URL: | https://refactor-method-names.tools-8rn.pages.dev |
eb2705d to
b2a613f
Compare
MichaReiser
approved these changes
Aug 24, 2022
b2a613f to
e510559
Compare
e510559 to
171b6f0
Compare
171b6f0 to
1360c54
Compare
1360c54 to
91f418d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes the methods compiled by
wasm_bindgencamel case. The reason why I changed it is because now the emitted types will be inline with the types emitted by thebackend-jsonrpcpackage, and this make the integration between the two backend easier.Test Plan
This is mostly a compile time change, as you can see the changes are reflected in the playground. The CI should pass.