This repository was archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_semantic): Improvements to scope resolution #3084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
bca3277
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7ead17f1.tools-8rn.pages.dev |
| Branch Preview URL: | https://feature-semantic-event-impro.tools-8rn.pages.dev |
2da478c to
67b370f
Compare
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
🎉 Fixed (1244):ts/babel
ts/microsoft
|
49271e1 to
b78e1bd
Compare
b7677fb to
5305bcf
Compare
5305bcf to
a768331
Compare
Out of curiosity, can you share some example? |
ematipico
suggested changes
Aug 23, 2022
Comment on lines
+270
to
+272
| | TS_INTERFACE_DECLARATION | ||
| | TS_ENUM_DECLARATION | ||
| | TS_TYPE_ALIAS_DECLARATION => { |
There was a problem hiding this comment.
Do we really create scopes for TS only syntax?
There was a problem hiding this comment.
Yes. Any reason you think we should not?
xtask/coverage/src/symbols/scope.js
Outdated
| @@ -0,0 +1,40 @@ | |||
| const parser = require("@babel/parser"); | |||
There was a problem hiding this comment.
Should this package be part of the PR? If so, could you please update the description of the PR and explain what's this used for?
There was a problem hiding this comment.
Should this package be part of the PR?
No. I will move these to another place. And push them in another PR.
a768331 to
bca3277
Compare
Argh.. Sorry, I thought I had removed these. |
ematipico
approved these changes
Aug 23, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR start to use the semantic model with our coverage test suites. See #3038.
This new "example" actually compares our scope resolution to other tools. Our compliance percentage is still quite low, especially because:
1 - Javascript tools use start/end as characters, we as bytes; when tests cases have Unicode it is very hard to compare values;
2 - Some tools treat trivia differently than us, so we need to sometimes use
text_range, and sometimes use the trimmed range;3 - Some tools create scopes that, as I understand, are not necessary.
Test Plan