This repository was archived by the owner on Aug 31, 2023. It is now read-only.
feat(playground): Use full height for right side panels #3072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR improves our playground to make use of the full height for the right hand side panels rather than 70% (which may result in scroll bars on small screens)
963edfb to
ffd9ace
Compare
Deploying with
|
| Latest commit: |
63e2d39
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://42068f9d.tools-8rn.pages.dev |
| Branch Preview URL: | https://feat-playground-heights.tools-8rn.pages.dev |
|
The issue now is that if we paste a long code, the scroll bar appears in a different way. Is it correct? Now Before |
|
I noticed that too when debugging binary expression formatting. Should now be fixed. |
xunilrj
approved these changes
Aug 17, 2022
|
I found a strange bug, not related to your PR. If I paste a big chunk of code, the prettier's output doesn't appear. |
ematipico
approved these changes
Aug 17, 2022
Have you checked the console output for any errors? |
Yes, and no errors |
|
You'll have to do some debugging then ;) |
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/tools
that referenced
this pull request
Aug 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves our playground to make use of the full height for the right hand side panels rather than 70% (which may result in scroll bars on small screens)
Test Plan