This repository was archived by the owner on Aug 31, 2023. It is now read-only.
test(rome_cli): more snapshot tests #3075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ematipico
commented
Aug 17, 2022
| @@ -0,0 +1,6 @@ | |||
| --- | |||
There was a problem hiding this comment.
These "empty" snapshots are expected because we don't read the Termination error yet. I plan to make another PR where we read the Result of a CLI session.
Deploying with
|
| Latest commit: |
67f75b7
|
| Status: | ⚡️ Build in progress... |
leops
approved these changes
Aug 17, 2022
ae18c34 to
a77a8c8
Compare
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/tools
that referenced
this pull request
Aug 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds more snapshot testing to our CLI tests.
I found the issue that was preventing us from applying the snapshot testing to the rest of the tests: there some tests where we manually open a file from the file system and inspect their content; when doing so, we lock the file via
.lock_arc(). This was preventing the snapshot logic to read these files unless they are freed.I manually added a
drop(file)where needed, and now we have more snapshots!Test Plan
CI should pass