This repository was archived by the owner on Aug 31, 2023. It is now read-only.
feat(npm): API facade and first compile pipeline #3074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1fd3175 to
a13c582
Compare
Deploying with
|
| Latest commit: |
56e0c3e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://78b45818.tools-8rn.pages.dev |
| Branch Preview URL: | https://feature-facade-apis.tools-8rn.pages.dev |
leops
reviewed
Aug 17, 2022
edd6c8d to
1b83afc
Compare
1b83afc to
8162b7c
Compare
MichaReiser
reviewed
Aug 18, 2022
d2260e0 to
c74a971
Compare
|
@MichaReiser @xunilrj any chance to get this approved so I can move onto the next piece of logic? |
c74a971 to
56e0c3e
Compare
xunilrj
approved these changes
Aug 23, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #3073
This PR starts works around the runtime APIs. This PR implements only few methods compared to the one proposed:
formatFilesformatContentparseContentThe return type of these methods are not final yet and should not be part of the review. For example having
contentforformatFilesdoesn't make sense.What's should be reviewed should be the input types for each API.
There are some tests that will fail once we start the actual work, there's some workflow with the GitHub actions and a compilation test with just TypeScript. Not sure if we really need a bundler for now.
Test Plan
Added new tests and updated an existing workflow. The reason why I didn't add
npm/romepath to the existing format workflow is because we usesetup-rome, which contains the old version, while I am using the current version onmainto format and check the JS code.I will make a new PR to change that across the board, so we are able to dogfood our JS code base while we develop.