+
Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

chore: update rust-toolchain to 1.63.0 #3053

Merged
merged 8 commits into from
Aug 15, 2022
Merged

chore: update rust-toolchain to 1.63.0 #3053

merged 8 commits into from
Aug 15, 2022

Conversation

IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented Aug 12, 2022 •
edited
Loading

Summary

  1. The latest stable rust-toolchain has been released, see https://blog.rust-lang.org/2022/08/11/Rust-1.63.0.html
  2. Fixing some lint errors introduced by this upgrade.

Test Plan

  1. CI should pass.

@IWANABETHATGUY IWANABETHATGUY requested a review from a team August 12, 2022 04:16
@IWANABETHATGUY IWANABETHATGUY changed the title chore: 🤖 update rust-toolchain to 1.63.0 chore: update rust-toolchain to 1.63.0 Aug 12, 2022
IWANABETHATGUY
IWANABETHATGUY commented Aug 12, 2022
View reviewed changes
IWANABETHATGUY
IWANABETHATGUY commented Aug 12, 2022
View reviewed changes
@IWANABETHATGUY
Copy link
Contributor Author

The two workarounds should open related tracking issues.

IWANABETHATGUY
IWANABETHATGUY commented Aug 12, 2022
View reviewed changes
crates/rome_analyze/src/visitor.rs
@@ -1,3 +1,4 @@
#![allow(rustdoc::broken_intra_doc_links)]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

false positive Clippy error introduced by this upgrade.

@IWANABETHATGUY IWANABETHATGUY mentioned this pull request Aug 12, 2022
Closed
6 tasks
@IWANABETHATGUY
Copy link
Contributor Author

Tracked here: #3054

@leops
Copy link
Contributor

leops commented Aug 12, 2022

Besides fixing the immediate warning and errors added in the upgrade, we should also track the possible improvements we can have thanks to the newly stabilized APIs:

  • With the standard library Mutex and RwLock being const-constructible it's now possible to use these in the DiffReport of the Prettier test suite
  • From Rust 1.62 it's now possible to derive the Default trait on enums, we could track down and remove the manual implementations for these
  • From Rust 1.61 the Termination trait and ExitCode type are now stable, meaning we could implement stable exit codes for the CLI (this could be done in the incoming refactor of diagnostics)

@IWANABETHATGUY
Copy link
Contributor Author

You are right, would you mind opening a new umbrella to tracking these issues? Because It seems that I don't have permission to create an umbrella issue with full functionality (I could not convert the todo items into separate task.)

@MichaReiser MichaReiser merged commit 5a059c0 into rome:main Aug 15, 2022
@MichaReiser
Copy link
Contributor

!bench_formatter

@MichaReiser
Copy link
Contributor

!bench_parser

@IWANABETHATGUY IWANABETHATGUY deleted the bump/toolchain branch August 15, 2022 08:50
@github-actions
Copy link

Parser Benchmark Results

group                                 main                                   pr
-----                                 ----                                   --
parser/checker.ts                     1.00    136.6±3.48ms    19.0 MB/sec    1.02    139.9±3.56ms    18.6 MB/sec
parser/compiler.js                    1.00     89.2±2.29ms    11.7 MB/sec    1.01     90.4±4.25ms    11.6 MB/sec
parser/d3.min.js                      1.00     51.1±0.94ms     5.1 MB/sec    1.01     51.6±1.05ms     5.1 MB/sec
parser/dojo.js                        1.00      4.6±0.08ms    15.0 MB/sec    1.01      4.6±0.07ms    14.8 MB/sec
parser/ios.d.ts                       1.01    120.3±3.11ms    15.5 MB/sec    1.00    118.5±2.89ms    15.7 MB/sec
parser/jquery.min.js                  1.00     13.9±0.33ms     6.0 MB/sec    1.02     14.1±0.33ms     5.9 MB/sec
parser/math.js                        1.00     97.0±2.60ms     6.7 MB/sec    1.05    101.5±3.11ms     6.4 MB/sec
parser/parser.ts                      1.00      3.2±0.05ms    14.9 MB/sec    1.00      3.2±0.05ms    14.9 MB/sec
parser/pixi.min.js                    1.00     60.0±1.57ms     7.3 MB/sec    1.01     60.8±1.51ms     7.2 MB/sec
parser/react-dom.production.min.js    1.00     18.8±0.36ms     6.1 MB/sec    1.01     19.0±0.27ms     6.1 MB/sec
parser/react.production.min.js        1.00  1027.3±16.54µs     6.0 MB/sec    1.02  1045.2±14.37µs     5.9 MB/sec
parser/router.ts                      1.00      2.7±0.05ms    22.3 MB/sec    1.02      2.8±0.04ms    21.9 MB/sec
parser/tex-chtml-full.js              1.00    129.8±3.28ms     7.0 MB/sec    1.09    141.5±8.83ms     6.4 MB/sec
parser/three.min.js                   1.00     68.2±1.86ms     8.6 MB/sec    1.03     70.0±1.78ms     8.4 MB/sec
parser/typescript.js                  1.00   578.6±17.44ms    16.4 MB/sec    1.00   575.8±14.07ms    16.5 MB/sec
parser/vue.global.prod.js             1.00     23.0±0.36ms     5.2 MB/sec    1.01     23.3±0.39ms     5.2 MB/sec

@IWANABETHATGUY
Copy link
Contributor Author

The regression seems not ideal, do we need to revert this?

@MichaReiser
Copy link
Contributor

I realized it too late that running the benchmarks after merging is useless because it then compares main (which includes 1.63) vs this branch (which is 1.63).

But it might be worth running the benchmarks locally before/after this commit.

@github-actions
Copy link

Formatter Benchmark Results

group                                    main                                   pr
-----                                    ----                                   --
formatter/checker.ts                     1.02    344.3±1.80ms     7.6 MB/sec    1.00    337.3±1.90ms     7.7 MB/sec
formatter/compiler.js                    1.10    229.0±9.54ms     4.6 MB/sec    1.00    208.1±1.30ms     5.0 MB/sec
formatter/d3.min.js                      1.00    167.5±1.48ms  1602.5 KB/sec    1.11    186.5±2.73ms  1439.3 KB/sec
formatter/dojo.js                        1.00     10.9±0.01ms     6.3 MB/sec    1.00     10.9±0.01ms     6.3 MB/sec
formatter/ios.d.ts                       1.00    232.3±1.02ms     8.0 MB/sec    1.00    231.4±0.99ms     8.1 MB/sec
formatter/jquery.min.js                  1.00     48.1±0.66ms  1759.4 KB/sec    1.01     48.7±0.75ms  1738.3 KB/sec
formatter/math.js                        1.05    366.3±2.68ms  1810.2 KB/sec    1.00    348.4±1.68ms  1903.5 KB/sec
formatter/parser.ts                      1.13      8.3±0.03ms     5.8 MB/sec    1.00      7.3±0.01ms     6.6 MB/sec
formatter/pixi.min.js                    1.01    213.2±1.92ms     2.1 MB/sec    1.00    212.0±1.56ms     2.1 MB/sec
formatter/react-dom.production.min.js    1.00     52.1±0.87ms     2.2 MB/sec    1.14     59.2±1.06ms  1989.9 KB/sec
formatter/react.production.min.js        1.00      3.0±0.01ms     2.0 MB/sec    1.00      3.0±0.00ms     2.0 MB/sec
formatter/router.ts                      1.00      5.7±0.00ms    10.8 MB/sec    1.12      6.4±0.00ms     9.6 MB/sec
formatter/tex-chtml-full.js              1.12    517.3±3.27ms  1803.8 KB/sec    1.00    461.9±4.84ms  2020.1 KB/sec
formatter/three.min.js                   1.11    244.7±2.41ms     2.4 MB/sec    1.00    220.3±1.49ms     2.7 MB/sec
formatter/typescript.js                  1.02   1446.3±9.26ms     6.6 MB/sec    1.00   1416.8±8.93ms     6.7 MB/sec
formatter/vue.global.prod.js             1.01     79.8±1.35ms  1545.6 KB/sec    1.00     79.1±4.08ms  1560.7 KB/sec

IWANABETHATGUY added a commit to IWANABETHATGUY/tools that referenced this pull request Aug 22, 2022
@IWANABETHATGUY
chore: update rust-toolchain to 1.63.0 (rome#3053)
0053160
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@leops leops Awaiting requested review from leops

@xunilrj xunilrj Awaiting requested review from xunilrj

@ematipico ematipico Awaiting requested review from ematipico

1 more reviewer

@MichaReiser MichaReiser MichaReiser approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@IWANABETHATGUY @leops @MichaReiser @xunilrj
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载