This repository was archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_syntax): Node factories for unknown nodes #3033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds node factory methods for unknown nodes. This is certainly more of an edge case, but I have a use case in the formatter when encountering an invalid parenthesized expression in which case the node should be replaced
as an unknown node so, for as far as the formatter is concerned, parenthesized expressions do not exist.
The new API can be used like this:
```rust
let unknown = rome_js_factory::make::js_unknown_expression(
root.slots().map(|slot| slot.into_syntax_element()),
);
```
## Alternatives
An alternative would be to directly use the `SyntaxNode::new_detached` APIs. This works but is less accessible and
it might be convenient to search for all places where we construct unknown nodes.
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
Deploying with
|
| Latest commit: |
1d78646
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://33ed544d.tools-8rn.pages.dev |
| Branch Preview URL: | https://feat-unknown-node-factory.tools-8rn.pages.dev |
Shouldn't we change how the parser emits the CST/AST in this case? To accommodate the use case? |
leops
approved these changes
Aug 9, 2022
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/tools
that referenced
this pull request
Aug 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds node factory methods for unknown nodes. This is certainly more of an edge case, but I have a use case in the formatter when encountering an invalid parenthesized expression in which case the node should be replaced
as an unknown node so, for as far as the formatter is concerned, parenthesized expressions do not exist.
The new API can be used like this:
Alternatives
An alternative would be to directly use the
SyntaxNode::new_detachedAPIs. This works but is less accessible andit might be convenient to search for all places where we construct unknown nodes.