This repository was archived by the owner on Aug 31, 2023. It is now read-only.
refactor(rome_rowan): Remove Clone requirement from trivia mutation methods
#3030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… methods Remove the requirement for `Clone` on the trivia mutation methods by changing the implementation so that it only iterates once over the new trivia rather than twice.
|
!bench_analyzer |
Deploying with
|
| Latest commit: |
33eee4e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://95f5b304.tools-8rn.pages.dev |
| Branch Preview URL: | https://refactor-rome-rowan-trivia-m.tools-8rn.pages.dev |
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
Analyzer Benchmark Results |
leops
approved these changes
Aug 9, 2022
xunilrj
reviewed
Aug 9, 2022
|
|
||
| text.push_str(self.text_trimmed()); | ||
| token_text.push_str(self.text_trimmed()); |
There was a problem hiding this comment.
You may be able to squeeze a lit bit more juice using self.raw.green().leading_trailing_total_len()directly.
There was a problem hiding this comment.
I implemented this change by slicing the self.text() directly.
xunilrj
approved these changes
Aug 9, 2022
|
!bench_analyzer |
Analyzer Benchmark Results |
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/tools
that referenced
this pull request
Aug 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the requirement for
Cloneon the trivia mutation methods by changing theimplementation so that it only iterates once over the new trivia rather than twice.