+
Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

feat(rome_js_semantic): semantic model "is_exported" query #3019

Merged
merged 6 commits into from
Aug 8, 2022

Conversation

xunilrj
Copy link
Contributor

@xunilrj xunilrj commented Aug 5, 2022

Summary

This PR implements the "is_exported" query in the SemanticModel.
It will be first used by the noUnusedVariables lint rule (#2979) to avoid false flags like

error[[js/noUnusedVariables](https://rome.tools/docs/lint/rules/noUnusedVariables/)]: This function is unused.
  ┌─ main.js:1:17
  
1  export function f() {

Test Plan

>  cargo test -p rome_js_semantic -- ok_semantic_model_is_exported

@xunilrj xunilrj temporarily deployed to aws August 5, 2022 21:00 Inactive
@xunilrj xunilrj changed the title Feature/semantic model is exported feat(rome_js_semantic): semantic model "is_exported" query Aug 5, 2022
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 5, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: eab3e5e
Status: ✅  Deploy successful!
Preview URL: https://ee80c1ac.tools-8rn.pages.dev
Branch Preview URL: https://feature-semantic-model-is-ex.tools-8rn.pages.dev

View logs

@xunilrj xunilrj temporarily deployed to aws August 5, 2022 21:04 Inactive
@github-actions
Copy link

github-actions bot commented Aug 5, 2022

@xunilrj xunilrj temporarily deployed to aws August 5, 2022 21:05 Inactive
Copy link
Contributor

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't hate the messenger, but we should also add the module.exports syntax.

@xunilrj
Copy link
Contributor Author

xunilrj commented Aug 8, 2022

Please don't hate the messenger, but we should also add the module.exports syntax.

That is true. I will do it in another PR.

@xunilrj xunilrj merged commit 66947bb into main Aug 8, 2022
@xunilrj xunilrj deleted the feature/semantic-model-is-exported branch August 8, 2022 07:55
IWANABETHATGUY pushed a commit to IWANABETHATGUY/tools that referenced this pull request Aug 10, 2022
IWANABETHATGUY pushed a commit to IWANABETHATGUY/tools that referenced this pull request Aug 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载