This repository was archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_js_analyze): Only emit diagnostic when alternate of JsIfStatement is JsBlockStatement
#3001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JsIfStatement is JsBlockStatementJsIfStatement is JsBlockStatement
ematipico
reviewed
Aug 4, 2022
leops
reviewed
Aug 4, 2022
leops
approved these changes
Aug 4, 2022
0c773c7 to
33a26ba
Compare
|
@leops is the PR good for merging? |
|
Well if no one has any objection to it I think it can be merged yes |
IWANABETHATGUY
added a commit
to IWANABETHATGUY/tools
that referenced
this pull request
Aug 10, 2022
…tement` is `JsBlockStatement` (rome#3001) * fix: 🐛 (rome_js_analyze): fix 2999 * fix: 🐛 cargo lnit * fix: 🐛 cr issue * fix: 🐛 cr issue * fix: 🐛 cr issue * fix: 🐛 cr issue
IWANABETHATGUY
added a commit
to IWANABETHATGUY/tools
that referenced
this pull request
Aug 22, 2022
…tement` is `JsBlockStatement` (rome#3001) * fix: 🐛 (rome_js_analyze): fix 2999 * fix: 🐛 cargo lnit * fix: 🐛 cr issue * fix: 🐛 cr issue * fix: 🐛 cr issue * fix: 🐛 cr issue
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
JsIfStatementisJsBlockStatementTest Plan