This repository was archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_rowan): Slots iterator last and size_hint
#2951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the `last` and `size_hint` implementations of the `SyntaxSlots` iterator. * `size_hint` should return the remaining items count in the iterator and not the total count of the underlying list. * `last` should return the last element remaining in the iterator, ignoring previously returned elements from calling `next_back` ## Tests I added new tests that verified the incorrect behaviour and then fixed the implementation
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
Deploying with
|
| Latest commit: |
e93bdfb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://58306964.tools-8rn.pages.dev |
| Branch Preview URL: | https://fix-syntax-slots.tools-8rn.pages.dev |
ematipico
approved these changes
Jul 28, 2022
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/tools
that referenced
this pull request
Aug 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the
lastandsize_hintimplementations of theSyntaxSlotsiterator.size_hintshould return the count of the remaining items in the iterator and not the total count of the underlying list.lastshould return the last element remaining in the iterator, ignoring previously returned elements from callingnext_backTests
I added new tests that verified the incorrect behaviour and then fixed the implementation