This repository was archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_formatter): If Statement Formatting #2957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ematipico
approved these changes
Jul 28, 2022
Deploying with
|
| Latest commit: |
7e3fe44
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://95e10da3.tools-8rn.pages.dev |
| Branch Preview URL: | https://feat-if-statement-formatting.tools-8rn.pages.dev |
This PR brings the formatting of `if` statements closer to Prettier's formatting * Don't wrap single statements in block statements * create group around `if` and `else` * Force `else` on a new line if consequent isn't a block statement This PR also fixes an issue where we added parentheses around string literals in places where this wasn't required.
554716a to
7e3fe44
Compare
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/tools
that referenced
this pull request
Aug 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR brings the formatting of
ifstatements closer to Prettier's formattingifandelseelseon a new line if consequent isn't a block statementThis PR also fixes an issue where we added parentheses around string literals in places where this wasn't required.
Test Plan
I manually verified that the snapshot changes match prettier's output.
File Based Average Prettier Similarity: 77.75% -> 77.98%
Line Based Average Prettier Similarity: 72.91% -> 73.23%