This repository was archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_js_analyze): include the exception handlers in the complexity score of the CFG #2930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y score of the CFG
Deploying with
|
| Latest commit: |
6623a9b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://34636680.tools-8rn.pages.dev |
| Branch Preview URL: | https://fix-cfg-exception-complexity.tools-8rn.pages.dev |
ematipico
approved these changes
Jul 26, 2022
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/tools
that referenced
this pull request
Aug 22, 2022
…y score of the CFG (rome#2930)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The additional control flow edges created by exception and finalization handlers were not being accounted for in the calculation of the complexity score for a control flow graph instance. This led to functions with a high control flow complexity being mistakenly run through the fine reachability analysis, with very poor performances due its exponential nature.
Test Plan
A new test case has been added to the
HighComplexitytests for thenoDeadCoderule that exhibits a pathological case of exponential complexity increase