This repository was archived by the owner on Aug 31, 2023. It is now read-only.
refactor(vscode): remove beta formatter options #2939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3f9cdb0 to
49080a2
Compare
Deploying with
|
| Latest commit: |
4b240bb
|
| Status: | ⚡️ Build in progress... |
49080a2 to
d860ae7
Compare
leops
reviewed
Jul 27, 2022
fa1f2eb to
05b84d3
Compare
05b84d3 to
379527f
Compare
leops
approved these changes
Jul 27, 2022
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/tools
that referenced
this pull request
Aug 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2938 .
Now that we have a configuration file, users should use that as source to change Rome's defaults. The options in the VSCode were always a beta, with the idea that they were going to be removed once the configuration file was available.
Now it's the time to remove them.
I enabled the serialization of
format_with_errorsand assigned its value to theWorkspaceSettings. This field it hasn't been used yet in the CLI. I will make a further PR to enable it.Test Plan
Current tests should pass. I manually built the VSCode extension and verified that the options don't exist anymore.