This repository was archived by the owner on Aug 31, 2023. It is now read-only.
docs: adds rome_rowan and the rome_js_parser to the deployed crates
#2913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
Deploying with
|
| Latest commit: |
b8d2218
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://dd133566.tools-8rn.pages.dev |
| Branch Preview URL: | https://docs-more-crates-to-dco.tools-8rn.pages.dev |
MichaReiser
approved these changes
Jul 21, 2022
| documentation = "doc -p rome_*formatter -p rome_control_flow -p rome_analyze -p rome_*_syntax -p rome_*_factory -p rome_diagnostics -p rome_service -p rome_cli -p rome_console --no-deps" | ||
| documentation = """ | ||
| doc \ | ||
| -p rome_*formatter \ |
There was a problem hiding this comment.
Any chance we can use rome_* or are there any rome crates that are excluded?
There was a problem hiding this comment.
There are few that should be hidden: lsp, text_edit, markup
There was a problem hiding this comment.
What's the reason for hiding those?
There was a problem hiding this comment.
No particular reason, but if have to think about it:
- LSP is purely an implementation over a trait of another crate
- same for text edit, it doesn't add much more
- not sure about markup
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
rome_rowanandrome_js_parserto the uploaded crates for our technical documentation.I fixed some warning but I am not sure if they are correct
Test Plan
Merge and check the deployed result.