+
Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

fix(rome_js_analyze/useTemplate): comments in trivia when merge Vec<JsAnyExpression> into a JsTemplate #2898

Merged
merged 5 commits into from
Jul 21, 2022
Merged

fix(rome_js_analyze/useTemplate): comments in trivia when merge Vec<JsAnyExpression> into a JsTemplate #2898

merged 5 commits into from
Jul 21, 2022

Conversation

IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented Jul 19, 2022 •
edited
Loading

Summary

  1. Handle case comments in trivia when merging Vec<JsAnyExpression> into a JsTemplate
  2. For more details, you could see feat(rome_js_analyze): useTemplate #2803 (comment)

Test Plan

  1. cargo test

@IWANABETHATGUY
Copy link
Contributor Author

!bench_analyzer

@github-actions
Copy link

Analyzer Benchmark Results

group                     main                                   pr
-----                     ----                                   --
analyzer/css.js           1.01      3.4±0.01ms     3.5 MB/sec    1.00      3.3±0.01ms     3.5 MB/sec
analyzer/index.js         1.01      7.1±0.07ms     4.6 MB/sec    1.00      7.0±0.04ms     4.6 MB/sec
analyzer/lint.ts          1.01      4.7±0.02ms     8.8 MB/sec    1.00      4.7±0.01ms     8.9 MB/sec
analyzer/parser.ts        1.00     10.9±0.08ms     4.4 MB/sec    1.00     10.9±0.26ms     4.4 MB/sec
analyzer/router.ts        1.01      7.0±0.01ms     8.5 MB/sec    1.00      6.9±0.01ms     8.6 MB/sec
analyzer/statement.ts     1.01      9.3±0.02ms     3.8 MB/sec    1.00      9.3±0.10ms     3.8 MB/sec
analyzer/typescript.ts    1.01     13.7±0.03ms     4.0 MB/sec    1.00     13.6±0.04ms     4.0 MB/sec

ematipico
ematipico approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! I left some nitpick, but it seems good to me

@IWANABETHATGUY IWANABETHATGUY force-pushed the fix/use-template-comment branch from 4da3c6b to 31f2039 Compare July 20, 2022 15:27
@ematipico ematipico merged commit e76b632 into rome:main Jul 21, 2022
@IWANABETHATGUY IWANABETHATGUY deleted the fix/use-template-comment branch July 21, 2022 07:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@xunilrj xunilrj Awaiting requested review from xunilrj

2 more reviewers

@ematipico ematipico ematipico approved these changes

@leops leops leops approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@IWANABETHATGUY @ematipico @leops
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载