This repository was archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_parser): Implement option-passing mechanism for parser test #4631 #4652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
29e868e to
40a8ac5
Compare
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
290b126 to
7762ee2
Compare
ematipico
approved these changes
Jul 5, 2023
crates/rome_js_parser/test_data/inline/err/ts_definite_variable_with_initializer.rast
Show resolved
Hide resolved
7762ee2 to
c8b5173
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Close #4631
Example:
test test_type test_name {parse_class_parameter_decorators: true/false }We need to parse JS parser options from comments and create a corresponding options file.
Test Plan
cargo test