This repository was archived by the owner on Aug 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 653
feat(rome_js_parser): Implement the decorator parsing via the option #4598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools canceled.
|
denbezrukov
commented
Jun 21, 2023
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
🎉 Fixed (1):
ts/babel
ts/microsoft
|
denbezrukov
commented
Jun 21, 2023
0e5fb05
to
9ab7211
Compare
ematipico
reviewed
Jun 23, 2023
crates/rome_js_formatter/tests/specs/prettier/typescript/decorators/inline-decorators.ts.snap
Show resolved
Hide resolved
crates/rome_js_formatter/tests/specs/prettier/typescript/decorators/inline-decorators.ts.snap
Outdated
Show resolved
Hide resolved
cfb082b
to
da874dc
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A-Formatter
Area: formatter
A-Linter
Area: linter
A-Parser
Area: parser
A-Tooling
Area: our own build, development, and release tooling
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Close #4595
Expand
JsFormalParameter
,JsRestParameter
,TsPropertyParameter
,TsThisParameter
with a decorator node:New syntax:
Test Plan
cargo test
Changelog
Documentation