+
Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

feat(rome_js_formatter) support prettier-style jsx quotes #4486 #4555

Merged
merged 1 commit into from
Jun 12, 2023
Merged

feat(rome_js_formatter) support prettier-style jsx quotes #4486 #4555

merged 1 commit into from
Jun 12, 2023

Conversation

denbezrukov
Copy link
Contributor

@denbezrukov denbezrukov commented Jun 8, 2023 •
edited by ematipico
Loading

Summary

Fix #4486

  • Added a new option "jsxQuoteStyle": "double" / "single", "double" by default.
  • Added a new control for the playground.

Test Plan

cargo test

Changelog

  • The PR requires a changelog line

Documentation

  • The PR requires documentation
  • I will create a new PR to update the documentation

@netlify
Copy link

netlify bot commented Jun 8, 2023 •
edited
Loading

✅ Deploy Preview for docs-rometools canceled.

Name Link
🔨 Latest commit 82704cf
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/6486c3a2a05c920008c5ff97

@github-actions github-actions bot added A-CLI Area: CLI A-Formatter Area: formatter A-Project Area: project configuration and loading labels Jun 8, 2023
@denbezrukov denbezrukov changed the title support prettier-style jsx quotes #4486 feat(rome_js_formatter) support prettier-style jsx quotes #4486 Jun 8, 2023
@denbezrukov denbezrukov marked this pull request as ready for review June 9, 2023 06:31
ematipico
ematipico approved these changes Jun 11, 2023
View reviewed changes
Copy link
Contributor

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, some nitpicks around documentation. Feel free to merge it!

@ematipico
Copy link
Contributor

I ticked the changelog line and the documentation checkboxes

@denbezrukov denbezrukov merged commit 659412a into main Jun 12, 2023
@denbezrukov denbezrukov deleted the feat/jsxQuoteStyle branch June 12, 2023 07:44
afc163 added a commit to ant-design/ant-design that referenced this pull request Jul 11, 2023
@afc163
chore: use rome again due to rome/tools#4555
525afa0
@afc163 afc163 mentioned this pull request Jul 11, 2023
Merged
20 tasks
afc163 added a commit to ant-design/ant-design that referenced this pull request Jul 13, 2023
@afc163
chore: use rome again due to rome/tools#4555
f167836
afc163 added a commit to ant-design/ant-design that referenced this pull request Jul 13, 2023
@afc163
chore: use rome again (#43492)
7ae5bc5 
* chore: use rome again due to rome/tools#4555

* Update package.json

Signed-off-by: afc163 <afc163@gmail.com>

* Apply suggestions from code review

Signed-off-by: afc163 <afc163@gmail.com>

* chore: use rome nightly version

---------

Signed-off-by: afc163 <afc163@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@ematipico ematipico ematipico approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-CLI Area: CLI A-Formatter Area: formatter A-Project Area: project configuration and loading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

📎 Support prettier-style jsx quotes

2 participants

@denbezrukov @ematipico
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载