This repository was archived by the owner on Aug 31, 2023. It is now read-only.
Workspace internal deps #4525
Merged
Workspace internal deps #4525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools canceled.Built without sensitive environment variables
|
…rkspace dependencies
ematipico
reviewed
May 22, 2023
|
|
||
| [dependencies] | ||
| rome_markup = { version = "0.0.1", path = "../rome_markup" } | ||
| rome_markup = { workspace = true } |
There was a problem hiding this comment.
Some crates have the version because they are published on crates.io.
We must keep the version in the main Cargo.toml
|
Could you please restore the template and fill it, please? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moved internal dependencies to the workspace.
Fixes #4515
Test Plan
Changelog
Documentation