This repository was archived by the owner on Aug 31, 2023. It is now read-only.
perf: improve rome benchmark performance in formatting by removing di… #4475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools canceled.Built without sensitive environment variables
|
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…agnostics
Summary
The benchmark tool was not passing
--max-diagnostics=0when performing the format benchmark forrome. It should be set as none of the other tools have any significant output - unlikerome, which by default was outputting up to 20 diagnostics per run.This improved
rome's performance in the format benchmark to the x25 speed improvement over Prettier, which is advertised on the homepage of the project. Without this,romeperformed worse thandprint.Test Plan
N/A
Changelog
I don't believe this requires a changelog entry
Documentation
The documentation was wrong before, this makes the documentation accurate again.