This repository was archived by the owner on Aug 31, 2023. It is now read-only.
fix: benchmark tooling failing calling node modules bin dir directly #4474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools canceled.Built without sensitive environment variables
|
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The benchmarking tool was not working on Windows or the
rustdocker image. This was due to calling thenode_modules.bindirectory directly. Which should be avoided. I did try usingnpxhowever as the child process that runshyperfineis ran in the working directory of the cloned repositories that did not work as anticipated.Test Plan
N/A
Changelog
I don't believe this requires a changelog entry
Documentation
This is a transparent fix and the documentation for the benchmark tool should not need updating.