This repository was archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_js_formatter): format JsxString node #4334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools canceled.
|
|
@nissy-dev I believe this PR requires a new line in the changelog. Could you tick the checkbox in the template and add an update to the |
ematipico
approved these changes
Mar 30, 2023
ematipico
approved these changes
Mar 31, 2023
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #4054
Rome doesn't format JsxString, so I applied FormatLiteralStringToken logic to JsxString node.
see: https://docs.rome.tools/playground/?indentStyle=space&code=YwBvAG4AcwB0ACAAQQAgAD0AIAAoACkAIAA9AD4AIAB7AAoAIAAgAHIAZQB0AHUAcgBuACAAPABkAGkAdgAgAHIAbwBsAGUAPQAiAG4AYQB2AGkAZwBhAHQAaQBvAG4AIgAgAC8APgAKAH0ACgAKAGMAbwBuAHMAdAAgAEIAIAA9ACAAKAApACAAPQA%2BACAAewAKACAAIAByAGUAdAB1AHIAbgAgADwAZABpAHYAIAByAG8AbABlAD0AJwBuAGEAdgBpAGcAYQB0AGkAbwBuACcAIAAvAD4ACgB9AA%3D%3D
Test Plan
I update the snapshot test
Changelog
Documentation