✅ Deploy Preview for docs-rometools canceled.

Built without sensitive environment variables

I have not implemented the options, should I also do that ?

If I should, I will need some guidance on options deserialization (doc seems to be outdated since #4160).

I have not implemented the options, should I also do that ?

If I should, I will need some guidance on options deserialization (doc seems to be outdated since #4160).

We can implement the rule without options for now. That part of the analyzer is still a bit unstable/subject to change

Thanks for your contribution! This looks good at first glance!

Our CI check the rules against the code of the website.
A code is triggering the rule:

website/src/playground/Playground.tsx:75:30 lint/nursery/noConfusingArrow  FIXABLE  ━━━━━━━━━━━━━━━━

  × Fat arrows can be confused with some comparison operators (<, >, <=, >=).
  
    73 │ 	const onUpdate = useCallback((viewUpdate: ViewUpdate) => {
    74 │ 		const cursorPosition = viewUpdate.state.selection.ranges[0]?.from ?? 0;
  > 75 │ 		setPlaygroundState((state) =>
       │ 		                           ^^
    76 │ 			state.cursorPosition !== cursorPosition
    77 │ 				? {
  
  i Safe fix: Wrap the function body in parenthesis.
  
     74  74 │   		const cursorPosition = viewUpdate.state.selection.ranges[0]?.from ?? 0;
     75  75 │   		setPlaygroundState((state) =>
     76     │ - → → → state.cursorPosition·!==·cursorPosition
         76 │ + → → → (
         77 │ + → → → state.cursorPosition·!==·cursorPosition
     77  78 │   				? {
     78  79 │   						...state,
     79  80 │   						cursorPosition,
     80  81 │   				  }
     81     │ - → → → → :·state,
         82 │ + → → → → :·state),
     82  83 │   		);
     83  84 │   	}, []);

The PR should thus fix the code that triggers the rule.

The PR should also be rebased against the branch main.

Once these two changes done, I think we can merge it :)

Rebased & applied the fix to Playground.tsx however there seems to be a conflict with the formatter which doesn't output parenthesis around the function body.

Rebased & applied the fix to Playground.tsx however there seems to be a conflict with the formatter which doesn't output parenthesis around the function body.

I think that website/src/playground/Playground.tsx format just need to be formatted with Rome or a compatible formatter such as Prettier. This should fix the issue.

What I meant is that this lint suggests adding parenthesis while rome format removes them. The formatter needs to be updated to take this into consideration.

What I meant is that this lint suggests adding parenthesis while rome format removes them. The formatter needs to be updated to take this into consideration.

We are better off removing the code action for the time being.

@malobre We recently changed the way to make PRs. Particularly, now PRs need to add a changelog line: https://github.com/rome/tools/blob/main/CONTRIBUTING.md#changelog

I added a line to the changelog, commented out the action and reverted the changes to Playground.tsx.
Also messed up the rebase, but I think its good now.

Edit: Fixed the commit author, sorry for all the noise

Fixed the commit author, sorry for all the noise

No problem :)

The CI is still failing. Could you set recommended to false? Hopefully, this will solve the issue. Sorry about this...