This repository was archived by the owner on Aug 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 653
feat(rome_service): add all
configuration to linter
#4258
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
c0ac510
to
e9532ca
Compare
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
7dbe4c6
to
0b62f2e
Compare
denbezrukov
reviewed
Mar 5, 2023
@@ -45,11 +49,19 @@ impl CliSnapshot { | |||
let mut content = String::new(); | |||
|
|||
if let Some(configuration) = &self.configuration { | |||
let parsed = parse_json(&redact_snapshot(configuration)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's so cool that we can use Rome json parse))))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I completely agree! I think it's a great way to dogfood Rome itself!
denbezrukov
approved these changes
Mar 5, 2023
fafa349
to
cb7e008
Compare
ematipico
added a commit
that referenced
this pull request
Mar 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new configuration to the
"linter"
section called"all"
.This configuration allows users to enable ALL rules or ALL rules for the given group.
recommended
andall
can't betrue
simultaneously; that's why I created a specific validation just for these cases.As for choosing the rules, the logic first checks if
rule
isSome()
and if so, enabled/disabled rules are updated. Ifall
isNone
, we fallback to check therecommended
flag (with its defaults).This option will be of great help, because it would allow us to use the playground and enable ALL rules without updating the TS code.
Test Plan
I created new test cases to ensure we selected the correct groups.
I also locally checked the playground to see if ALL rules are enabled.
Documentation