This repository was archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_formatter): format range has incorrect source map #4149 #4241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#4149
This PR tries to fix several issues when we format a node with a range.
detach
a node if it updates a tree (splice_slots
) while a traversing. We must return transformed a node back into the original tree to correct offset and sometimes a formatting result depends on aparent
kind.Test Plan
cargo test
Documentation