+
Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

Conversation

ematipico
Copy link
Contributor

@ematipico ematipico commented Feb 14, 2023

Summary

I don't have a Windows machine, so it's really hard for me to fix this issue. For now, I have enabled windows testing on PRs, too, to catch these kinds of issues early.

Then, I excluded the tests causing issues from running on Windows.

Test Plan

CI should pass

Documentation

  • The PR requires documentation
  • I will create a new PR to update the documentation

@netlify
Copy link

netlify bot commented Feb 14, 2023

Deploy Preview for docs-rometools ready!

Name Link
🔨 Latest commit f3052b3
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/63ee18e06dcdc00009feae49
😎 Deploy Preview https://deploy-preview-4209--docs-rometools.netlify.app/playground
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ematipico ematipico force-pushed the chore/better-testing-coverage branch 2 times, most recently from de000c4 to 145da55 Compare February 14, 2023 13:57
@ematipico ematipico force-pushed the chore/better-testing-coverage branch from 145da55 to 8660b70 Compare February 14, 2023 14:23
@ematipico ematipico marked this pull request as ready for review February 16, 2023 11:59
@ematipico ematipico added this pull request to the merge queue Feb 16, 2023
Merged via the queue into main with commit e88b826 Feb 16, 2023
@ematipico ematipico deleted the chore/better-testing-coverage branch February 16, 2023 12:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载