+
Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

chore: update rust and dependencies #4152

Merged
merged 2 commits into from
Feb 3, 2023
Merged

chore: update rust and dependencies #4152

merged 2 commits into from
Feb 3, 2023

Conversation

ematipico
Copy link
Contributor

Summary

This PR updates the toolchain version and tokio version.

Test Plan

The existing CI should pass

Documentation

  • The PR requires documentation
  • I will create a new PR to update the documentation

@ematipico ematipico requested a review from a team as a code owner January 12, 2023 13:20
@netlify
Copy link

netlify bot commented Jan 12, 2023 •
edited
Loading

✅ Deploy Preview for docs-rometools canceled.

Name Link
🔨 Latest commit 4d377d1
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/63dcefaa09ced100086aa1f2

leops
leops reviewed Jan 12, 2023
View reviewed changes
Copy link
Contributor

@leops leops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this PR supersede #4121 ?

Also looking at the failed cargo audit on CI, it seems the additional warnings could be solved by updating the following crates:

  • tracing-tree to 0.2.1
  • tracing-subscriber to 0.3.16
  • manually upgrading the entry for plotters to 0.3.4 in Cargo.lock

@ematipico
Copy link
Contributor Author

manually upgrading the entry for plotters to 0.3.4 in Cargo.lock

How do you do it? Just changing the version number is not enough, because the checksum fails.

@leops
Copy link
Contributor

leops commented Jan 12, 2023

manually upgrading the entry for plotters to 0.3.4 in Cargo.lock

How do you do it? Just changing the version number is not enough, because the checksum fails.

I think running cargo update -p plotters should work

@github-actions
Copy link

This PR is stale because it has been open 14 days with no activity.

@ematipico
Copy link
Contributor Author

I pinned the tokio version because tower_lsp was pulling a different version, causing multiple versions of the same dep. This is now fixed, and we can move on! :)

@github-actions
Copy link

github-actions bot commented Feb 3, 2023

Parser conformance results on ubuntu-latest

js/262

Test result main count This PR count Difference
Total 48647 48647 0
Passed 47582 47582 0
Failed 1065 1065 0
Panics 0 0 0
Coverage 97.81% 97.81% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6093 6093 0
Passed 1754 1754 0
Failed 4339 4339 0
Panics 0 0 0
Coverage 28.79% 28.79% 0.00%

ts/babel

Test result main count This PR count Difference
Total 639 639 0
Passed 567 567 0
Failed 72 72 0
Panics 0 0 0
Coverage 88.73% 88.73% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 16740 16740 0
Passed 12816 12816 0
Failed 3924 3924 0
Panics 0 0 0
Coverage 76.56% 76.56% 0.00%

@github-actions github-actions bot removed the S-Stale label Feb 3, 2023
@ematipico ematipico merged commit 6acb40e into main Feb 3, 2023
@ematipico ematipico deleted the fix/cve-issue branch February 3, 2023 12:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leops leops leops left review comments

@xunilrj xunilrj Awaiting requested review from xunilrj

@MichaReiser MichaReiser Awaiting requested review from MichaReiser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ematipico @leops
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载