This repository was archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_cli): Enable JSON formatting #4133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
ematipico
approved these changes
Jan 3, 2023
leops
reviewed
Jan 3, 2023
95310b6 to
c7ad9f8
Compare
Closed
6 tasks
Signed-off-by: Micha Reiser <micha@famreiser.ch>
Signed-off-by: Micha Reiser <micha@famreiser.ch>
Signed-off-by: Micha Reiser <micha@famreiser.ch>
Co-authored-by: Superchupu <53496941+SuperchupuDev@users.noreply.github.com>
d7bbe2f to
b514444
Compare
I enabled the JSON formatting for the VSCode extension locally. The files are ignored :) |
|
If Rome ignores |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables JSON formatting for all builds.
The CLI ignores the
package.json,package-lock.jsonandtsconfig.jsonby default.Test Plan
Ran the cli on the rome repository.
Documentation
Updating the website to remove the "coming soon" from the JSON icon is necessary.
Open questions
How to ignore the
package.json... files from within the editor