This repository was archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_analyzer): no duplicate jsx props rule #4095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
ca08b5b to
a812019
Compare
xunilrj
reviewed
Dec 22, 2022
crates/rome_js_analyze/src/analyzers/nursery/no_duplicate_jsx_props.rs
Outdated
Show resolved
Hide resolved
xunilrj
reviewed
Dec 22, 2022
crates/rome_js_analyze/src/analyzers/nursery/no_duplicate_jsx_props.rs
Outdated
Show resolved
Hide resolved
xunilrj
reviewed
Dec 22, 2022
crates/rome_js_analyze/src/analyzers/nursery/no_duplicate_jsx_props.rs
Outdated
Show resolved
Hide resolved
xunilrj
reviewed
Dec 22, 2022
crates/rome_js_analyze/src/analyzers/nursery/no_duplicate_jsx_props.rs
Outdated
Show resolved
Hide resolved
xunilrj
reviewed
Dec 22, 2022
crates/rome_js_analyze/src/analyzers/nursery/no_duplicate_jsx_props.rs
Outdated
Show resolved
Hide resolved
xunilrj
reviewed
Dec 22, 2022
crates/rome_js_analyze/src/analyzers/nursery/no_duplicate_jsx_props.rs
Outdated
Show resolved
Hide resolved
xunilrj
reviewed
Dec 22, 2022
crates/rome_js_analyze/src/analyzers/nursery/no_duplicate_jsx_props.rs
Outdated
Show resolved
Hide resolved
xunilrj
reviewed
Dec 22, 2022
crates/rome_js_analyze/src/analyzers/nursery/no_duplicate_jsx_props.rs
Outdated
Show resolved
Hide resolved
c1d224e to
65bb445
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
New lint rule to disallow duplicate properties in JSX
Closes #4029
Test Plan
cargo test -p rome_js_analyze -- no_duplicate_jsx_propsYou can see the results in the valid and invalid snapshots
Documentation